Add a build command for dapp images #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ll help! |
I'll hold of reviewing this then |
chmanie
reviewed
Sep 27, 2019
| qs: { | ||
| 'circle-token': process.env.CIRCLE_CI_API_KEY, | ||
| auth: { | ||
| 'user': process.env.CIRCLE_CI_API_KEY |
There was a problem hiding this comment.
Interesting that the above didn't work. Circle docs said it would be ok 🤔 (https://circleci.com/docs/api/#add-an-api-token). But if it's working I don't really care how in this case :)
There was a problem hiding this comment.
Ah, I didn't even know this was a possibility - I just transposed the curl one liner I was using to the request properties. I haven't tried, but looking in the docs, maybe we were missing a I think that's just the syntax they're using.: at the start of the API key?
chmanie
reviewed
Sep 27, 2019
| @@ -178,14 +178,13 @@ module.exports = async function(robot) { | |||
|
|
|||
| robot.hear(/!build (goerli|mainnet) ([0-9a-fA-f]*)/, async msg => { | |||
| const buildInfo = await request({ | |||
| method: 'POST', | |||
There was a problem hiding this comment.
Haha, that's a pretty obvious one. Sorry!
|
LGTM, thanks @area! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the CircleCI API, we can trigger the build workflow from chewie.
Syntax:
!build (goerli|mainnet) <commithash>I don't think anyone is proposing removing the mainnet build in the dapp from a merge to master, but thought I'd include it for completeness anyway. Once this is merged, I believe removing this block from the Dapp CircleCI config will prevent it from running on commits, but will still leave it available for this build command.
Yup, I've done it with curl rather than 'properly' with request. Consider it a TODO for the future 😛Thanks for keeping me honest, Chris!