Fix: Release expenditure stage via motion

src/graphql/generated.ts

@@ -624,6 +624,8 @@ export enum ColonyActionType {
   PaymentMultisig = 'PAYMENT_MULTISIG',
   /** An action related to the recovery functionality of a Colony */
   Recovery = 'RECOVERY',
+  /** An action related to a motion to release a staged payment */
+  ReleaseStagedPaymentMotion = 'RELEASE_STAGED_PAYMENT_MOTION',
   /** An action related to removing verified members */
   RemoveVerifiedMembers = 'REMOVE_VERIFIED_MEMBERS',
   RemoveVerifiedMembersMotion = 'REMOVE_VERIFIED_MEMBERS_MOTION',
@@ -1663,6 +1665,7 @@ export type CreateExpenditureInput = {
 };
 
 export type CreateExpenditureMetadataInput = {
+  distributionType?: InputMaybe<SplitPaymentDistributionType>;
   fundFromDomainNativeId: Scalars['Int'];
   id?: InputMaybe<Scalars['ID']>;
   stages?: InputMaybe<Array<ExpenditureStageInput>>;
@@ -2277,6 +2280,11 @@ export type ExpenditureFundingItemInput = {
 export type ExpenditureMetadata = {
   __typename?: 'ExpenditureMetadata';
   createdAt: Scalars['AWSDateTime'];
+  /**
+   * Specifies the distribution type selected when creating a split payment
+   * Will be null for other payment types
+   */
+  distributionType?: Maybe<SplitPaymentDistributionType>;
   fundFromDomainNativeId: Scalars['Int'];
   id: Scalars['ID'];
   stages?: Maybe<Array<ExpenditureStage>>;
@@ -3428,6 +3436,7 @@ export type ModelExpenditureFilterInput = {
 
 export type ModelExpenditureMetadataConditionInput = {
   and?: InputMaybe<Array<InputMaybe<ModelExpenditureMetadataConditionInput>>>;
+  distributionType?: InputMaybe<ModelSplitPaymentDistributionTypeInput>;
   fundFromDomainNativeId?: InputMaybe<ModelIntInput>;
   not?: InputMaybe<ModelExpenditureMetadataConditionInput>;
   or?: InputMaybe<Array<InputMaybe<ModelExpenditureMetadataConditionInput>>>;
@@ -3441,6 +3450,7 @@ export type ModelExpenditureMetadataConnection = {
 
 export type ModelExpenditureMetadataFilterInput = {
   and?: InputMaybe<Array<InputMaybe<ModelExpenditureMetadataFilterInput>>>;
+  distributionType?: InputMaybe<ModelSplitPaymentDistributionTypeInput>;
   fundFromDomainNativeId?: InputMaybe<ModelIntInput>;
   id?: InputMaybe<ModelIdInput>;
   not?: InputMaybe<ModelExpenditureMetadataFilterInput>;
@@ -3845,6 +3855,11 @@ export enum ModelSortDirection {
   Desc = 'DESC',
 }
 
+export type ModelSplitPaymentDistributionTypeInput = {
+  eq?: InputMaybe<SplitPaymentDistributionType>;
+  ne?: InputMaybe<SplitPaymentDistributionType>;
+};
+
 export type ModelStreamingPaymentConditionInput = {
   and?: InputMaybe<Array<InputMaybe<ModelStreamingPaymentConditionInput>>>;
   createdAt?: InputMaybe<ModelStringInput>;
@@ -4310,6 +4325,7 @@ export type ModelSubscriptionExpenditureMetadataFilterInput = {
   and?: InputMaybe<
     Array<InputMaybe<ModelSubscriptionExpenditureMetadataFilterInput>>
   >;
+  distributionType?: InputMaybe<ModelSubscriptionStringInput>;
   fundFromDomainNativeId?: InputMaybe<ModelSubscriptionIntInput>;
   id?: InputMaybe<ModelSubscriptionIdInput>;
   or?: InputMaybe<
@@ -7688,6 +7704,12 @@ export enum SortingMethod {
   ByMorePermissions = 'BY_MORE_PERMISSIONS',
 }
 
+export enum SplitPaymentDistributionType {
+  Equal = 'EQUAL',
+  Reputation = 'REPUTATION',
+  Unequal = 'UNEQUAL',
+}
+
 export type StakedExpenditureParams = {
   __typename?: 'StakedExpenditureParams';
   stakeFraction: Scalars['String'];
@@ -8891,6 +8913,7 @@ export type UpdateExpenditureInput = {
 };
 
 export type UpdateExpenditureMetadataInput = {
+  distributionType?: InputMaybe<SplitPaymentDistributionType>;
   fundFromDomainNativeId?: InputMaybe<Scalars['Int']>;
   id: Scalars['ID'];
   stages?: InputMaybe<Array<ExpenditureStageInput>>;

src/handlers/expenditures/stagedPaymentReleased.ts

@@ -39,7 +39,7 @@ export const handleStagedPaymentReleased: EventHandler = async (
   });
   const metadata = response?.data?.getExpenditureMetadata;
 
-  if (!metadata || !metadata.stages) {
+  if (!metadata?.stages) {
     output(
       `Could not find stages data for expenditure with ID: ${databaseId}. This is a bug and needs investigating.`,
     );

src/handlers/motions/motionCreated/handlers/expenditures/index.ts

@@ -1,3 +1,4 @@
 export { default as handleCancelStakedExpenditureMotion } from './cancelStakedExpenditures';
 export { default as handleCancelExpenditureViaArbitrationMotion } from './cancelExpenditureViaArbitration';
 export { default as handleFinalizeExpenditureViaArbitrationMotion } from './finalizeExpenditureViaArbitration';
+export { default as handleReleaseStagedPaymentViaArbitration } from './releaseStagedPaymentViaArbitration';

src/handlers/motions/motionCreated/handlers/expenditures/releaseStagedPaymentViaArbitration.ts

@@ -0,0 +1,35 @@
+import { BigNumber } from 'ethers';
+import { TransactionDescription } from 'ethers/lib/utils';
+import { ContractEvent, motionNameMapping } from '~types';
+import { createMotionInDB } from '../../helpers';
+import {
+  getDomainDatabaseId,
+  getExpenditureDatabaseId,
+  toNumber,
+} from '~utils';
+
+export default async (
+  event: ContractEvent,
+  { name, args: actionArgs }: TransactionDescription,
+  gasEstimate: BigNumber,
+): Promise<void> => {
+  const { args, colonyAddress } = event;
+  const [, , , , expenditureId] = actionArgs;
+  const [, , domainId] = args;
+
+  if (!colonyAddress) {
+    return;
+  }
+
+  await createMotionInDB(event, {
+    type: motionNameMapping[name],
+    fromDomainId: colonyAddress
+      ? getDomainDatabaseId(colonyAddress, domainId)
+      : undefined,
+    gasEstimate: gasEstimate.toString(),
+    expenditureId: getExpenditureDatabaseId(
+      colonyAddress,
+      toNumber(expenditureId),
+    ),
+  });
+};

src/handlers/motions/motionCreated/motionCreated.ts

@@ -27,6 +27,7 @@ import {
   handleMetadataDeltaMotion,
   handleCancelExpenditureViaArbitrationMotion,
   handleFinalizeExpenditureViaArbitrationMotion,
+  handleReleaseStagedPaymentViaArbitration,
 } from './handlers';
 import { ExtensionEventListener } from '~eventListeners';
 
@@ -186,6 +187,15 @@ export const handleMotionCreated: EventHandler = async (
         break;
       }
 
+      case ColonyOperations.ReleaseStagedPaymentViaArbitration: {
+        await handleReleaseStagedPaymentViaArbitration(
+          event,
+          parsedAction,
+          gasEstimate,
+        );
+        break;
+      }
+
       default: {
         break;
       }

src/types/motions.ts

@@ -23,6 +23,7 @@ export enum ColonyOperations {
   EditColonyByDelta = 'editColonyByDelta',
   CancelExpenditureViaArbitration = 'cancelExpenditureViaArbitration',
   FinalizeExpenditureViaArbitration = 'finalizeExpenditureViaArbitration',
+  ReleaseStagedPaymentViaArbitration = 'releaseStagedPaymentViaArbitration',
 }
 
 export enum MotionEvents {
@@ -66,6 +67,8 @@ export const motionNameMapping: { [key: string]: ColonyActionType } = {
     ColonyActionType.FinalizeExpenditureMotion,
   [ColonyOperations.SetExpenditureState]:
     ColonyActionType.SetExpenditureStateMotion,
+  [ColonyOperations.ReleaseStagedPaymentViaArbitration]:
+    ColonyActionType.ReleaseStagedPaymentMotion,
 };
 
 export enum MotionSide {