Avoid factoring zero (oscar-system#3104)

JohnAAbbott · Dec 13, 2023 · 13c3fc3 · 13c3fc3
1 parent 6d999d6
commit 13c3fc3
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/experimental/MatroidRealizationSpaces/src/realization_space.jl b/experimental/MatroidRealizationSpaces/src/realization_space.jl
@@ -657,6 +657,7 @@ end
 
 # removes factors that are in the semigroup generated by Sgens
 function clean(f::RingElem, R::MPolyRing, Sgens::Vector{<:RingElem})
+  is_zero(f) && return f # TODO: move to the right place
   fFactors = factor(f)
   cleanf_arr = [k^e for (k, e) in fFactors if !(k in Sgens) || is_unit(k)]
   length(cleanf_arr) > 0 ? prod(cleanf_arr) : unit(fFactors)