Remove deprecations

[jodastephen]

Summary by CodeRabbit

• New Features

  • Improved readability and maintainability by using a factory method for locale instantiation across various test classes.

• Bug Fixes

  • Enhanced clarity in test methods by simplifying string handling in assertions, ensuring the same functionality is maintained without confusion.

• Chores

  • Modernised code by replacing direct instantiation of locale objects with a static method, promoting best practices in code quality.

[coderabbitai]

Walkthrough

Walkthrough

The changes across the test files focus on updating the instantiation of Locale objects from using the constructor to a static factory method, Locale.of(...). This modification enhances code readability and maintainability without altering the overall functionality of the tests. Additionally, some tests were made slightly clearer through minor adjustments in variable assignments.

Changes

Files Group	Change Summary
src/test/java/org/joda/money/...	Updated instantiation of Locale objects to use Locale.of(...) instead of new Locale(...), improving readability and maintainability.
src/test/java/org/joda/money/format/...	Similar updates for Locale instantiation; minor enhancement in clarity through variable assignments in tests without changing underlying logic.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Test Class
    participant Locale as Locale Factory

    Test->>Locale: Locale.of("en", "XY")
    Locale-->>Test: Returns Locale instance
    Test->>Test: Proceed with tests

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[jodastephen]

@coderabbitai review

[coderabbitai]

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c7ba6ef and 7db7b46.

Files selected for processing (4)

• src/test/java/org/joda/money/TestCurrencyUnit.java (1 hunks)
• src/test/java/org/joda/money/format/TestMoneyAmountStyle.java (1 hunks)
• src/test/java/org/joda/money/format/TestMoneyFormatter.java (2 hunks)
• src/test/java/org/joda/money/format/TestMoneyFormatterBuilder.java (1 hunks)

Files skipped from review due to trivial changes (3)

• src/test/java/org/joda/money/format/TestMoneyAmountStyle.java
• src/test/java/org/joda/money/format/TestMoneyFormatter.java
• src/test/java/org/joda/money/format/TestMoneyFormatterBuilder.java

Additional comments not posted (1)

src/test/java/org/joda/money/TestCurrencyUnit.java (1)

418-419: Use of Locale.of(...) is appropriate.

The change to use Locale.of("en", "XY") instead of new Locale("en", "XY") aligns with modern Java practices and enhances code readability. The test logic remains correct.