Added vcl support for custom snippets and various other options and changed defaults #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che_settings, added various ssl options for backend, and changed the default vaules to NULL when the option was optional to the fastly api call so settings aren't changes in unintentional ways
|
I will write documentation and some tests when I have time. |
|
Also parts of the code are based and/or copied from Pull Request 16 to give credit to @himyouten |
|
Due to the numerous defaults I have changed to remove extra variables being set, many tests are broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added vcl support for custom snippets, added ttl config option for cache_settings, added various ssl options for backend, and changed the default vaules to NULL when the option was optional to the fastly api call so settings aren't changes in unintentional ways
I have not written tests or documentation for my changes yet although I have tested the changes.