refactor: add structured logging with slog
#199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbruens
changed the title
slogslog
fortuna
approved these changes
Aug 19, 2024
service/tcp.go
Outdated
| // between Go's inlining/escape analysis and varargs functions like slog.Debug. | ||
| if slog.Default().Enabled(context.TODO(), slog.LevelDebug) { | ||
| args = append(args, slog.String("ID", cipherID)) | ||
| slog.Debug(fmt.Sprintf("TCP: %s", template), args...) |
There was a problem hiding this comment.
FYI. I guess it doesn't matter for debug, but LogAttrs is the most efficient way to log: https://pkg.go.dev/golang.org/x/exp/slog#hdr-Attrs_and_Values
There was a problem hiding this comment.
Good point. Done, even if it's just for debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR keeps the status quo of logging to the default logger. This doesn't change the fact that we log in the service library. Ideally the library part doesn't log, that should be up the client, but leaving it as a TODO to rethink that in a future PR.
Tint seems to be the go-to for tinted/colored logs if we want to keep that feature, but I could revert to just plain text logging.
Screenshot: