feat(server): add getTunneltime to manager metrics #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
requested changes
Aug 23, 2024
daniellacosse
commented
Aug 26, 2024
daniellacosse
commented
Aug 26, 2024
daniellacosse
force-pushed
the
daniellacosse/tunneltime/add_get_tunneltime
branch
from
40975be
to
cf4383b
Compare
sbruens
reviewed
Sep 12, 2024
sbruens
reviewed
Sep 13, 2024
sbruens
approved these changes
Sep 16, 2024
fortuna
requested changes
Sep 16, 2024
fortuna
reviewed
Sep 17, 2024
fortuna
reviewed
Sep 24, 2024
| @@ -40,4 +58,21 @@ export class PrometheusManagerMetrics implements ManagerMetrics { | |||
| } | |||
| return {bytesTransferredByUserId: usage}; | |||
| } | |||
|
|
|||
| async getTunnelTimeByLocation({ | |||
There was a problem hiding this comment.
This is no longer by location. It's broken down by all dimensions. Please rename.
There was a problem hiding this comment.
The metric name is shadowsocks_tunnel_time_seconds_per_location as opposed to the shadowsocks_tunnel_time_seconds metric - does that matter to you?
| export type TunnelTimeDimension = 'access_key' | 'country' | 'asn'; | ||
|
|
||
| interface TunnelTimeRequest { | ||
| time_window: { |
There was a problem hiding this comment.
Let's define a Duration type and reuse
There was a problem hiding this comment.
You mean like...
interface Duration {
hours?: number;
seconds?: number;
}What happens if both hours and seconds are there?
| @@ -599,6 +601,23 @@ export class ShadowsocksManagerService { | |||
| } | |||
| } | |||
|
|
|||
| async getTunnelTimeByLocation(req: RequestType, res: ResponseType, next: restify.Next) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
successful result from digital ocean droplet:
TODOs: