fix: validate only if limit is defined

Jigsaw-Code · Jan 26, 2023 · 09f88bf · 09f88bf
1 parent e2c45d3
commit 09f88bf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/shadowbox/server/manager_service.ts b/src/shadowbox/server/manager_service.ts
@@ -338,8 +338,11 @@ export class ShadowsocksManagerService {
         );
       }
 
-      const limit = (req.params.limit as DataLimit) || undefined;
-      const dataLimit = validateDataLimit(limit);
+      const dataLimit = (req.params.limit as DataLimit) || undefined;
+
+      if (dataLimit) {
+        validateDataLimit(dataLimit);
+      }
 
       const accessKeyJson = accessKeyToApiJson(
         await this.accessKeys.createNewAccessKey({encryptionMethod, name, dataLimit})

diff --git a/src/shadowbox/server/server_access_key.spec.ts b/src/shadowbox/server/server_access_key.spec.ts
@@ -60,7 +60,7 @@ describe('ServerAccessKeyRepository', () => {
 
   it('New access keys sees the encryption method correctly', (done) => {
     const repo = new RepoBuilder().build();
-    repo.createNewAccessKey('aes-256-gcm').then((accessKey) => {
+    repo.createNewAccessKey({encryptionMethod: 'aes-256-gcm'}).then((accessKey) => {
       expect(accessKey).toBeDefined();
       expect(accessKey.proxyParams.encryptionMethod).toEqual('aes-256-gcm');
       done();