Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop lint task from being automatically cancelled #2338

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: stop lint task from being automatically cancelled #2338

merged 1 commit into from
Jan 22, 2025

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Jan 22, 2025 •
edited
Loading

Annoyingly, the lint task belongs to the same concurrency group as some of our other tasks, so it kept being cancelled. This PR fixes that.

@daniellacosse daniellacosse changed the title fix: add lint task to its own concurrency group so it stops being can… fix: stop lint task from being automatically cancelled Jan 22, 2025
@daniellacosse daniellacosse requested a review from sbruens January 22, 2025 15:33
@daniellacosse daniellacosse marked this pull request as ready for review January 22, 2025 15:33
@daniellacosse daniellacosse requested a review from a team as a code owner January 22, 2025 15:33
sbruens
sbruens approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I was wondering why it sometimes doesn't run.

@daniellacosse daniellacosse merged commit a368f72 into master Jan 22, 2025
31 checks passed
@daniellacosse daniellacosse deleted the daniellacosse/lint_concurrency branch January 22, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbruens sbruens sbruens approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniellacosse @sbruens