chore(manager): remove duplicate lit module

[daniellacosse]

current findings:

1. tried all the stuff in https://lit.dev/docs/tools/development/, didn't work for getting rid of the multiple dependencies, but gave useful context.
2. Then I had the idea to use npm's override feature instead - at first to force all our dependencies to use lit@3 and @lit/[email protected]. This didn't work as npm can't force versions upon dependencies that those dependencies don't accept:

3. Then I tried using override to enforce [email protected] instead, as it seemed that was the version all our dependencies would accept:

As you can see, this successfully removed the multiple versions of lit warning from the tests!

4. However, the app broke. The "new key" dialog freezes when you edit it, similar to how the rename dialog did before we used the mwc component as a workaround. This further lends credence to the idea that @material/web (the more modern md prefixed web components) don't play well with the older lit versions and that upgrading to 3 will ultimately fix this issue.

---

At this point, I think our only option is to use Webpack to force resolution of lit throughout our build (something I was trying to avoid):

const path = require('path');

module.exports = {
  // ... other webpack configurations
  resolve: {
    alias: {
      // This will make sure that any dependency that imports 'lit' or any of its sub-modules
      // will use the version you installed in step 1
      lit: path.resolve(__dirname, 'node_modules/lit'),
      'lit/*': path.resolve(__dirname, 'node_modules/lit/*'),
    },
  },
};

This is a little tricky given our monorepo structure, but doable.

Out of scope would be to switch back to yarn, as yarn 2+ has really precise controls for managing the dependencies of your dependencies.

Also, we should probably let the lit team (?) know about the overrides trick I discovered? That way they can update their documentation to be more helpful.

[daniellacosse]

The webpack method worked! Now I just need to clean this up a little bit.

[daniellacosse]

Unfortunately, I tried upgrading the mwc-textfield and it still remains uneditable in the iOS 15.5 simulator. I'll try again tomorrow on a real device once I'm in the office. Here's the diff:

diff --git a/client/src/www/views/servers_view/server_list_item/server_card/server_rename_dialog/index.ts b/client/src/www/views/servers_view/server_list_item/server_card/server_rename_dialog/index.ts
index cb4f64f2..e624608c 100644
--- a/client/src/www/views/servers_view/server_list_item/server_card/server_rename_dialog/index.ts
+++ b/client/src/www/views/servers_view/server_list_item/server_card/server_rename_dialog/index.ts
@@ -60,14 +60,14 @@ export class ServerRenameDialog extends LitElement {
           On older versions of iOS, md-textfield triggers itself indefinitely here,
           so we must use mwc-textfield
         -->
-        <mwc-textfield
+        <md-filled-text-field
           slot="content"
           maxLength="100"
           value="${this.internalServerName}"
           @input=${(e: Event) => {
             this.internalServerName = (e.target as HTMLInputElement).value;
           }}
-        ></mwc-textfield>
+        ></md-filled-text-field>
         <fieldset slot="actions">
           <md-text-button @click=${this.handleClose}
             >${this.localize('cancel')}</md-text-button

[sbruens]

LGTM assuming this works

[daniellacosse]

LGTM assuming this works

So on my iOS 15.5 device using the md-filled-text-field is... now slightly better? Nothing freezes, but you have to tap the input a ton of times and then you can do one keystroke :/