Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): increase padding to account for safe area #2252

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix(client): increase padding to account for safe area #2252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2ccbf4
fix(client): increase padding to account for safe area
yakovmanshin Oct 18, 2024
ee4b073
Merge branch 'master' into zero-state-footer-padding
daniellacosse Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/www/views/servers_view/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export class ServerList extends LitElement {
}
footer {
border-top: 1px solid rgba(0, 0, 0, 0.08);
padding: 24px 0 16px;
padding: 24px 0 max(16px, env(safe-area-inset-bottom));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max() was added in Chrome 79. Not sure if it covers every supported OS version, but since the related min() function is already used in the project, I figured it’s fine to use max() here.

text-align: center;
}
button {
Expand Down
Loading