Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions during SkiaSwingLayer rendering #816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle exceptions during SkiaSwingLayer rendering #816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions skiko/src/awtMain/kotlin/org/jetbrains/skiko/swing/SkiaSwingLayer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ open class SkiaSwingLayer(
redrawerManager.findNextWorkingRenderApi()
repaint()
}
} catch (e: Exception) {
Logger.warn(e) { "Exception during SkiaSwingLayer rendering" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-sasha I agree, but I would say that this part of the framework is crucial, so not handling exceptions here would cause completely broken view (like in attached issue)

Copy link
Member

@m-sasha m-sasha Oct 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why would there be exceptions here? Is it not better to discover and fix them instead?
In Compose we catch exceptions at the window level and typically show an error dialog followed by shutting down the application. Why is that not a good policy here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They can appear only because of the broken internal contracts (out mistakes) and for sure they should be fixed. Like here JetBrains/compose-multiplatform-core#878

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we should introduce this policy for swing bridge then too. Do you think it would be better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend that, yes. I wonder what @igordmn thinks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had similar code in the past (try-catch-log for rendering), and it was bad UX for end users (the window just stops to draw). We moved exception handling responsibility to SkikoView, as exceptions happen on its level, and it knows what to do with it.

In case of Swing components (which ComposePanel is), what is the policy for exceptions during rendering?

Regarding what policy we choose, we should implement it on the ComposeBridge level. Actually it is already implemented (see ComposePanel.exceptionHandler), we just need to define the default behavior.

Copy link
Member

@m-sasha m-sasha Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of Swing components (which ComposePanel is), what is the policy for exceptions during rendering?

Looks like it just calls the thread's uncaught exception handler (from EventDispatchThread.pumpOneEventForFilters). The default handler just prints the stack trace to stderr.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is the case, it seems everything already works this way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only by default (which I also think is a bad idea). In Swing I can set the thread's uncaught exception handler and change the behavior.

}
}

Expand Down