KT-28492: Include sources in kotlin-osgi-bundle #5361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatbrot
force-pushed
the
kotlin-osgi-bundle-sources
branch
from
987f423 to
c42abb7
Compare
|
@Tapchicoma Not sure if "Maven Plugin" is the correct label here, since I am not changing anything at the kotlin maven plugin. Instead, I am just fixing a build issue for "kotlin-osgi-bundle" :) |
Tapchicoma
force-pushed
the
kotlin-osgi-bundle-sources
branch
from
c42abb7 to
080e0bf
Compare
Tapchicoma
force-pushed
the
kotlin-osgi-bundle-sources
branch
from
080e0bf to
d25aa49
Compare
With this change, we include the sources of all dependencies of `kotlin-osgi-bundle` in its source bundle. This gives users of this library a better IDE and debugging experience providing documentation and allows users to debug in the stdlib. This implementation works very similarly on how the class files of the dependencies are merged. This also means that currently conflicts are not handled at all. This is probably fine, since there should actually be no duplicates. ^KT-28492 Fixed
Tapchicoma
force-pushed
the
kotlin-osgi-bundle-sources
branch
from
1e74347 to
eab538a
Compare
Tapchicoma
approved these changes
Jan 7, 2025
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we include the sources of all dependencies of
kotlin-osgi-bundlein its source bundle.This gives users of this library a better IDE and debugging experience
providing documentation and allows users to debug in the stdlib.
This implementation works very similarly on how the class files of the
dependencies are merged. This also means that currently conflicts are
not handled at all.
This is probably fine, since there should actually be no duplicates.
^KT-28492 Fixed
Screenshot of the sources jar:
