Fix null reference initialising output panel fonts #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes VIM-3515
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an exception that would prevent debugging in Rider. The Debug tool window would create an
Editorinstance during initialisation and set the font size. If the font size was changed (e.g. the editor was zoomed), then IdeaVim's font property change listener would try to hide the ex command line and the output panel. Unfortunately, this forced creation of the output panel, which would try to position itself, but because theEditorinstance hadn't been added to the UI, the editor component's root pane would be null, and lead to aNullPointerException.This PR adds a null check to avoid the exception, and also avoids creating the panel just to make sure it's hidden.
Fixes VIM-3515