-
Notifications
You must be signed in to change notification settings - Fork 88
Compose UI for native Linux #2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jb-main
Are you sure you want to change the base?
Conversation
e34932a
to
8b01930
Compare
e9269fd
to
c9a9317
Compare
|
||
|
||
internal actual suspend fun ClipEntry.readText(): String? { | ||
return null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many features in this PR are not implemented (this is just one random example). I am afraid that using wayland code here could break it for non-wayland apps.
My use case is using Compose on an embedded system which is not using wayland but manufacturer specific APIs for most (windowing) features. I need to implement some of these functions with manufacturer-specific code, which of course can never be merged into compose.
As this is an expect/actual (like almost everywhere), I do not know of an easy way to pull out the wayland code into a separate module. Ideally a user like me can provide their own implementation for the windowing features. Or maybe multiple separate modules (one for wayland, etc). Any ideas what would work best?
90cedfe
to
7d57ea9
Compare
7d57ea9
to
9abf814
Compare
|
||
import kotlinx.coroutines.CoroutineDispatcher | ||
|
||
lateinit var ComposeUiMainDispatcher: CoroutineDispatcher // TODO: https://github.com/Kotlin/kotlinx.coroutines/issues/4286 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is just to gather some feedback, definitely not ready to merge. A lot of code is missing or just copied from other platforms. Which has to be implemented with probably something like Wayland. Preferably not breaking usage on embedded systems without Wayland if possible.
Depends on:
To build this branch use a local version of skiko containing JetBrains/skiko#1051. For EGL this is needed as well: