Skip to content
This repository has been archived by the owner on Jun 3, 2022. It is now read-only.

chore(indexer): removed await within test due to race condition #743

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind chore

What this PR does / why we need it:

As suggested by @monstrobishi in #733 to remove await within tests that were added due to race condition.

@codeclimate
Copy link

codeclimate bot commented Jan 31, 2022

Code Climate has analyzed commit 5dc6879 and detected 0 issues on this pull request.

View more on Code Climate.

monstrobishi
monstrobishi previously approved these changes Jan 31, 2022
src/e2e.module.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #743 (5dc6879) into main (7d535b7) will decrease coverage by 0.04%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   92.31%   92.27%   -0.05%     
==========================================
  Files         121      122       +1     
  Lines        3163     3183      +20     
  Branches      384      389       +5     
==========================================
+ Hits         2920     2937      +17     
- Misses        234      237       +3     
  Partials        9        9              
Impacted Files Coverage Δ
src/module.indexer/rpc.block.provider.ts 89.77% <86.66%> (-3.49%) ⬇️
src/e2e.module.ts 92.06% <100.00%> (-0.37%) ⬇️
...rc/module.database/provider.level/cbor.encoding.ts 100.00% <100.00%> (ø)
...c/module.database/provider.level/level.database.ts 93.40% <100.00%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349876d...5dc6879. Read the comment docs.

@monstrobishi
Copy link
Contributor

Seems like the active price test failure is due to the test executing faster, or some similar difference in timing. That test has proven to be flakey, will add a ticket to investigate at some stage.

@fuxingloh fuxingloh marked this pull request as draft February 18, 2022 07:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants