Skip to content
This repository has been archived by the owner on Jun 3, 2022. It is now read-only.

add addresses to vout #407

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

p3root
Copy link

@p3root p3root commented Sep 27, 2021

/kind feature

What this PR does / why we need it:

Add Addresses to vout information

@codeclimate
Copy link

codeclimate bot commented Sep 27, 2021

Code Climate has analyzed commit 734a60f and detected 0 issues on this pull request.

View more on Code Climate.

@fuxingloh fuxingloh self-assigned this Sep 27, 2021
@fuxingloh
Copy link
Contributor

Hey, thanks for opening #407 and #393. I will review, add tests and merge this in soon.

Just to let you know the direction of this project, we are building 2 APIs concurrently. as part of BirthdayResearch/jellyfishsdk#580 and Rust node move. We are separating and moving more indexing responsibilities to jellyfish.

The current API (this project) will be a full node compatible build and will still be worked on.

We are also working on another API that doesn't rely on defid, this new API which is in planning now will resolve the mountain of issues we face while building this API namely https://github.com/DeFiCh/whale/issues/50 and https://github.com/DeFiCh/whale/issues/51. This move is necessary to resolve the technical debt we accumulated in the early days that bring out Ocean API fast.

@fuxingloh fuxingloh marked this pull request as draft November 3, 2021 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants