Updated Noble Fork #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffontaine
reviewed
Nov 19, 2020
| @@ -20,7 +20,7 @@ | |||
|
|
|||
| // System: HTTP server and Bluetooth Low Energy Library | |||
| const winston = require("./logger"); | |||
| const noble = require("noble"); | |||
| const noble = require("@abandonware/noble"); | |||
There was a problem hiding this comment.
Thanks for this PR, it helped me a lot to make it work on a RPi 4.
However, it should be noted that package.json must also be updated:
"dependencies": {
"@abandonware/noble": "1.9.2-10",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the updated noble fork there should be fewer bluetooth-hci-socket failures. If the socket continues to fail, install @abandonware/bluetooth-hci-socket while in fluffd directory. The folder may need to be copied into modules folder, have not had the chance to test yet. It definately does work if you overwrite the noble folder and copy the newer hci socket module into the main modules folder (they will be installed under a folder named @abandonware)