Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert workaround -Wstringop-overflow warnings from fmt #319

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix: revert workaround -Wstringop-overflow warnings from fmt #319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41ec2cf
fix: revert workaround -Wstringop-overflow warnings from fmt
c-dilks Jan 3, 2025
1192f85
ci: re-trigger, since previous attempt still used 11.0
c-dilks Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/iguana/services/Logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,8 @@
#pragma once

// workaround https://github.com/fmtlib/fmt/issues/4133
#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wshift-overflow"
#else
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wstringop-overflow"
#endif
#include <fmt/color.h>
#include <fmt/format.h>
#include <fmt/ranges.h>
#ifdef __clang__
#pragma clang diagnostic pop
#else
#pragma GCC diagnostic pop
#endif

#include <functional>
#include <unordered_map>
Expand Down
Loading