Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with running bg-merger twice and add more functionalities #390

Merged
merged 8 commits into from
Dec 31, 2024

Conversation

raffaelladevita
Copy link
Collaborator

@baltzell
Copy link
Collaborator

Did we lose the error return value in the engine's init?

@baltzell
Copy link
Collaborator

baltzell commented Dec 13, 2024

Let's make sure the default settings, e.g., which detectors are enabled, are what most people should want (and what should be used on OSG).

@raffaelladevita
Copy link
Collaborator Author

Let's make sure the default settings, e.g., which detectors are enabled, are what most people should want (and what should be used on OSG).

done

@raffaelladevita
Copy link
Collaborator Author

Did we lose the error return value in the engine's init?

The error is now returned by the setgFiles method

@baltzell
Copy link
Collaborator

Is engine's init always returning good now?

@raffaelladevita
Copy link
Collaborator Author

raffaelladevita commented Dec 16, 2024 via email

@baltzell baltzell merged commit 3896b8f into development Dec 31, 2024
68 checks passed
@baltzell baltzell deleted the iss373-bgMergeTwice branch December 31, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants