-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
Hi @pankhurivanjani I'm Nacho. One of JdeRobot's collaborators. I've been reviewing the Pull Request you've made about the CamViz documentation and I wanted, first of all, to congratulate you for having done it so quickly. In this way we already have a first approach to the documentation of this repository. I replicated your repository to see the result before the merge and it seems that the cover is missing content. Since this is the first time we include this template in a repository, it will be the test for future ones :-) In the test, I configured Front Matter of
The result can be seen in the image. Maybe if we added more text in the white space below plus an image of the project and the video that you put in the installation we can better fill the cover of the project, what do you think? If you like, we make these small changes and publish it like this. |
Hello again @pankhurivanjani . I have reviewed the changes and if they fit me more. I centered the image (with a "trick" that comes inside the minimal mistake's template) and removed the "info" section that I think didn't make much sense on its own. The changes have been to the
If you like, we can integrate them like this. I like the rest of the components (installation and ROS section in the navigation bar):-) In next videos, you can use the open source software:
The reason for recommending this software is to increase the resolution in the videos to FullHD, since the text in the video looks a little blurred. It won't let me use 1080p quality. I'm sorry for so much text, it's for trying to keep a course as fixed as possible for the documentation of the Software. Great job and thanks for the dedication and effort ;-) Nacho. |
Hello @igarag , Thank you for the review. I will update the changes after 5th October. About the video quality, I also felt the blurred text an issue. I am currently using Simple Screen Recorder but this. The colcon build takes time to build in ROS1 as well as ROS2. Due to which the video extended to 4-5 minutes. I was suggested to keep it in 1-2 min time limit. So, while processing the video via online editor the quality of the video is degrading. So, maybe we can avoid the time limit thing here? |
Ooohh, i see. Hmm, another option is to edit the video. In this link are the 9 most used editors for Linux (especially the first 4). You can record the video with SimpleScreenRecorder and in the part of the installation that takes more time, accelerate it with a 4x, for example. How do you see it? Nacho. |
Solves #1 and #2 .
This PR aims to submit the new version of purely rosified camViz tool.