Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate use of globals to generate ids #371

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Eliminate use of globals to generate ids #371

merged 3 commits into from
Jul 17, 2024

Conversation

bdraco
Copy link
Collaborator

@bdraco bdraco commented Jun 17, 2024

BREAKING CHANGE:

Accessory now requires an aid
Accessory.create_with_info now requires an aid

@bdraco bdraco marked this pull request as draft June 17, 2024 16:39
@bdraco
Copy link
Collaborator Author

bdraco commented Jun 17, 2024

need to fix the CI. Will do that in another PR first after lunch

@bdraco
Copy link
Collaborator Author

bdraco commented Jun 17, 2024

also I think #370 is ready to go. I don't have any more crashes on the devices mentioned in the linked issue anymore

bdraco added a commit to home-assistant/core that referenced this pull request Jun 17, 2024
@bdraco bdraco changed the title eliminate use of globals to generate ids Eliminate use of globals to generate ids Jun 17, 2024
@bdraco bdraco marked this pull request as ready for review June 17, 2024 18:33
@bdraco bdraco merged commit 2e223d7 into main Jul 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants