Fix IP exceptions referencing the old host var #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #352 +/- ##
=======================================
Coverage 74.50% 74.50%
=======================================
Files 99 99
Lines 9301 9301
=======================================
Hits 6930 6930
Misses 2371 2371 ☔ View full report in Codecov by Sentry. |
Jc2k
approved these changes
Dec 28, 2023
bdraco
commented
Dec 28, 2023
|
(Feel free to merge/release this and other fixes for beta - busy with family so won't be as reliable for acks). |
Hopefully this is the only one. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have multi-ip support but when I refactored, I missed some old
.hostvariables in the exception text