cors issue fixed

JaveedIshaq · Dec 15, 2024 · 01e49ff · 01e49ff
1 parent a6b0868
commit 01e49ff
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -3,7 +3,7 @@ name: Deploy to GitHub Pages
 on:
   push:
     branches:
-      - main  # or your default branch
+      - main
   workflow_dispatch:
 
 jobs:
@@ -30,14 +30,17 @@ jobs:
           echo "EMAILJS_TEMPLATE_ID=${{ secrets.EMAILJS_TEMPLATE_ID }}" >> $GITHUB_ENV
 
       - name: Build
-        run: npm run build -- --configuration production --base-href "https://javeedishaq.github.io/"
+        run: npm run build -- --configuration production
+
+      - name: Create CNAME
+        run: echo "www.javeedishaq.com" > dist/ngdevfolio/browser/CNAME
 
       - name: Deploy to javeedishaq.github.io
         uses: peaceiris/actions-gh-pages@v3
         with:
           personal_token: ${{ secrets.PERSONAL_TOKEN }}
           external_repository: JaveedIshaq/javeedishaq.github.io
-          publish_branch: main  # Deploy to main branch
+          publish_branch: main
           publish_dir: dist/ngdevfolio/browser
-          cname: www.javeedishaq.com  
-
+          cname: www.javeedishaq.com
+          enable_jekyll: false
diff --git a/angular.json b/angular.json
@@ -43,22 +43,23 @@
               "budgets": [
                 {
                   "type": "initial",
-                  "maximumWarning": "500kB",
-                  "maximumError": "1MB"
+                  "maximumWarning": "500kb",
+                  "maximumError": "1mb"
                 },
                 {
                   "type": "anyComponentStyle",
-                  "maximumWarning": "4kB",
-                  "maximumError": "8kB"
+                  "maximumWarning": "2kb",
+                  "maximumError": "4kb"
                 }
               ],
+              "outputHashing": "all",
+              "baseHref": "/",
               "fileReplacements": [
                 {
                   "replace": "src/environments/environment.ts",
                   "with": "src/environments/environment.prod.ts"
                 }
-              ],
-              "outputHashing": "all"
+              ]
             },
             "development": {
               "optimization": false,