Add retry mechanism to CompoundRateProvider.getExchangeRate on failure
#419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the getExchangeRate method in the CompoundRateProvider class to introduce a failFast parameter. Previously, the method would immediately throw an exception on the first provider failure. This change allows for a more flexible approach by adding an option to continue attempting to get an exchange rate from subsequent providers if failFast is set to false. - Added a new overloaded getExchangeRate method with a failFast boolean parameter. - If failFast is true, the method retains the original behavior of failing immediately on the first exception. - If failFast is false, the method logs a warning and continues to the next provider in case of an exception. This update addresses some of the limitations described in issue JavaMoney#385.
sernamar
changed the title
CompoundRateProvider.getExchangeRate on failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a retry mechanism to
CompoundRateProvider.getExchangeRateby adding an overloaded version with afailFastparameter:failFastis set totrue, the method retains its original behavior, throwing an exception immediately on the first provider failure.failFastis set tofalse, the method logs a warning and continues attempting to retrieve an exchange rate from the next provider.This way users can choose whether to fail immediately or attempt to use other providers if one fails. The default behavior remains unchanged (i.e., fails immediately), ensuring backward compatibility.
This change addresses issue #385 and provides more flexibility in handling provider failures.
This change is