ErrorPage 에 헤더, 하단Nav바 추가 및 FallbackPage구현 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 렌더링중일때 showHeaderTitle값이 true인 버그 수정
- fallback으로 FallbackPage 추가
|
🎉 @imb96 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏 |
imb96
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ PR 타입
✨ 기능 설명 or 🚨 문제 상황
👨💻 구현 내용 or 👍 해결 내용
feat: 헤더, 하단Nav바에 onNavigate props 추가
feat: queryClient default option 추가
feat: ErrorPage 에 헤더, 하단Nav바 추가
fix: useHeaderTitle 훅 수정
feat: FallbackPage 추가
refactor: 최상위에 Suspense 하나만 두게 변경
fix: FallbackPage 헤더 제거
🎯 PR 포인트
📝 참고 사항
앞으로 페이지 구현해서 router에 적용 시 Suspense로 묶지 않아도 됩니다.
Layout.tsx 안에 Outlet을 Suspense로 묶어두었습니다.
❓ 궁금한 점