Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save yarn locally to workaround setup-node issue #47

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

shakuzen
Copy link
Contributor

@shakuzen shakuzen commented Nov 19, 2023

Setup-node refuses to add an option for enabling corepack due to it being marked experimental. This unwittingly resulted in us using the globally installed yarn v1 version for building on GitHub Actions, despite our expectation that yarn v4 would be used. Rather than do a dance of enabling corepack and setting up node, this saves yarn locally and checks it into git.

Also bumps yarn from 4.0.1 to 4.0.2.

See actions/setup-node#899 which we started seeing, for example https://github.com/JapanFinance/JapanFinance.github.io/actions/runs/6909375623/job/18800585931?pr=46. It doesn't happen on every build, as a rebuild passed.
This situation could have been avoided if setup-node had an option to enable corepack; see actions/setup-node#531.

Setup-node refuses to add an option for enabling corepack due to it being marked experimental.
This unwittingly resulted in us using the globally installed yarn v1 version for building, despite our expectation that yarn v4 would be used.
Rather than do a dance of enabling corepack and setting up node, this saves yarn locally and checks it into git.
Copy link

argos-ci bot commented Nov 19, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Nov 19, 2023, 3:08 AM

@shakuzen shakuzen merged commit 6ac5c0a into JapanFinance:main Nov 19, 2023
2 checks passed
@shakuzen shakuzen deleted the local-yarn branch November 19, 2023 03:11
shakuzen added a commit to shakuzen/JapanFinance.github.io that referenced this pull request Aug 3, 2024
Setup-node refuses to add an option for enabling corepack due to it being marked experimental.
This unwittingly resulted in us using the globally installed yarn v1 version for building, despite our expectation that yarn v4 would be used.
Rather than do a dance of enabling corepack and setting up node, this saves yarn locally and checks it into git.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant