Add Pontus Networks per offline-signed CCLA #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Misha Brukman <[email protected]>
|
LGTM |
|
@pluradj What are we supposed to review if we can't see the signed CLA? I can basically only review that the format is correct, but say nothing about the content. |
|
Florian's comment is related to the issue #131 and discussion https://groups.google.com/forum/#!topic/janusgraph-dev/3l8UIK-sKAY (second issue in the discussion) |
|
@FlorianHockmann @porunov Fair. I've considered the review here mostly as a final check from the person listed on the CLA on the details of the items. Reviewers are looking for correct format of the details, placement in the CLA file, and comparing email address with existing PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to the JanusGraph project, @pontusvision! We look forward to your contributions.