Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to the janusgraph-visualizer #4712

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

porunov
Copy link
Member

@porunov porunov commented Nov 3, 2024


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@porunov porunov added this to the Release v1.1.0 milestone Nov 3, 2024
@@ -41,8 +41,10 @@ provides links to documentation, getting-started guides and release downloads.

## Visualization

To visualize graphs stored in JanusGraph, you can use any of the following
tools:
JanusGraph has a web-based graph visualizer located in [janusgraph-visualizer](https://github.com/JanusGraph/janusgraph-visualizer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice the below section still mentions [Gremlin-Visualizer](https://github.com/prabushitha/gremlin-visualizer). Shall we somehow remove that and mention this is a fork of that? Or any other wording to avoid confusion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a sentence to clarify that this was the original repository on which JanusGraph was built on.
I think, it makes sense to leave it in case gremlin-visualizer will decide to diverge in the future. In that case, users will be able to choose between visualizers they prefer more.
That said, I doubt it will diverge, so I'm OK just removing it as well.

Signed-off-by: Oleksandr Porunov <[email protected]>
Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@porunov porunov merged commit 66fdcc7 into JanusGraph:master Nov 3, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants