Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the circular initialization dependency #4658 #4663

Closed

Conversation

ministat
Copy link
Contributor

Fix the issue #4658:

ModifierType and TypeDefinitionCategory has circular initialization dependency, as a result, if we access ModifierType before TypeDefinitionCategory, it will cause java.lang.ExceptionInInitializerError problem.

A UT is included. No document change.

Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Copy link

linux-foundation-easycla bot commented Aug 30, 2024

CLA Missing ID CLA Not Signed

ModifierType and TypeDefinitionCategory has circular initialization dependency,
as a result, if we access ModifierType before TypeDefinitionCategory, it will
cause java.lang.ExceptionInInitializerError problem.

Signed-off-by: Hongjiang Zhang <[email protected]>
@ministat ministat force-pushed the hj_fix_enum_circular_dependency branch from 17b7c84 to 121270b Compare August 30, 2024 05:54
@ministat
Copy link
Contributor Author

I think I know the problem. The following information is obtained by checking the PR URL by adding ".patch" postfix. The email is different from the Signed-off-by. I guess that caused the EasyCLA to fail. Let me fix this.

From 17b7c845407c774f6724ca4956415853d25c9614 Mon Sep 17 00:00:00 2001
From: Zhang Hongjiang <[email protected]>
Date: Mon, 26 Aug 2024 15:37:02 +0800
Subject: [PATCH] Fix the circular initialization dependency

ModifierType and TypeDefinitionCategory has circular initialization dependency,
as a result, if we access ModifierType before TypeDefinitionCategory, it will
cause java.lang.ExceptionInInitializerError problem.

Signed-off-by: Hongjiang Zhang <[email protected]>

@ministat
Copy link
Contributor Author

It looks I have to re-create this PR again since the email address does not change.

@ministat ministat closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant