Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only java 11 #4040

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only java 11 #4040

wants to merge 1 commit into from

Conversation

farodin91
Copy link
Contributor

@farodin91 farodin91 commented Oct 8, 2023


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@farodin91 farodin91 marked this pull request as draft October 8, 2023 19:23
@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Oct 8, 2023
@farodin91 farodin91 marked this pull request as ready for review October 9, 2023 04:56
@farodin91 farodin91 added this to the Release v1.0.0 milestone Oct 9, 2023
@li-boxuan
Copy link
Member

@farodin91 Do you think we can do this in the next major release, e.g. 2.0.0? We could send an announcement (that java 8 will no longer be supported) once 1.0.0 is released.

@farodin91
Copy link
Contributor Author

@li-boxuan We can move this to 2.0.
We have to change the upcoming latest version in the build pipeline.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Signed-off-by: Jan Jansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/skip cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants