Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logmanager.sh #9702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update logmanager.sh #9702

wants to merge 1 commit into from

Conversation

mzico
Copy link
Contributor

@mzico mzico commented Oct 9, 2024

Update for Janssen arch.

Prepare


Description

Target issue

closes #issue-number-here

Implementation Details


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Closes #9703,

Update for Janssen arch. 

Signed-off-by: mzico <[email protected]>
Copy link

dryrunsecurity bot commented Oct 9, 2024

DryRun Security Summary

The pull request modifies a log management script, "logmanager.sh", to work with the Janssen application instead of the previous Gluu application, and expands the list of directories where log files are managed, while ensuring proper access controls and permissions are in place to prevent unauthorized access or modification of log files.

Expand for full summary

Summary:

The changes in this pull request appear to be a modification to a log management script called "logmanager.sh". The script is responsible for compressing and deleting log files that are older than a certain number of days. The key changes include updating the script to work with the Janssen application instead of the previous Gluu application, as well as expanding the list of directories where log files are managed. From an application security perspective, the changes in this script are not particularly concerning, as log management is a common and necessary task for any application. However, it's important to ensure that the script is only deleting the intended files and that proper access controls and permissions are in place to prevent unauthorized access or modification of log files.

Files Changed:

  • jans-linux-setup/jans_setup/static/scripts/logmanager.sh: This script has been modified to work with the Janssen application instead of the previous Gluu application. The key changes include:
    1. Updating the directory paths and log file locations to match the Janssen application.
    2. Compressing and deleting log files from several new directories, including /opt/jans/jetty/jans-auth/logs, /opt/jans/jetty/jans-casa/logs, /opt/jans/jetty/jans-config-api/logs, and others.
    3. Changing the log file location from /opt/gluu/logs/logmanager.log to /var/log/logmanager.log.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added the comp-jans-linux-setup Component affected by issue or PR label Oct 9, 2024
@mo-auto
Copy link
Member

mo-auto commented Oct 9, 2024

Error: Hi @mzico, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

Copy link

sonarcloud bot commented Oct 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-linux-setup Component affected by issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Update logmanager.sh -autocreated
3 participants