Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[do-not-merge] Support metadata markdown #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[do-not-merge] Support metadata markdown #3

wants to merge 4 commits into from

Conversation

grgprarup
Copy link

@grgprarup grgprarup commented Nov 10, 2023 •
edited
Loading

  • Modified reveal.js markdown plugin so that supports markdown with metadata
  • Added unit test for markdown with metadata
  • Added templates for slide types

NOTE:: Ignore the changes in files dist/reveal.css, dist/reveal.esm.js, dist/reveal.js, package-lock.json, plugin/markdown/markdown.esm.js, and plugin/markdown/markdown.js

@grgprarup grgprarup force-pushed the support-metadata-markdown branch from 92af801 to b1c096c Compare November 13, 2023 05:23
@grgprarup grgprarup marked this pull request as ready for review November 13, 2023 05:23
saw-jan
saw-jan reviewed Nov 13, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was it by formatter?

plugin/markdown/plugin.js Outdated Show resolved Hide resolved
plugin/markdown/plugin.js Outdated Show resolved Hide resolved
plugin/markdown/plugin.js Outdated Show resolved Hide resolved
saw-jan
saw-jan reviewed Nov 13, 2023
View reviewed changes
plugin/markdown/plugin.js Outdated Show resolved Hide resolved
plugin/markdown/plugin.js Outdated Show resolved Hide resolved
saw-jan
saw-jan reviewed Nov 13, 2023
View reviewed changes
plugin/markdown/plugin.js Outdated Show resolved Hide resolved
@grgprarup grgprarup force-pushed the support-metadata-markdown branch from b1c096c to 4379cf1 Compare November 13, 2023 11:32
@grgprarup grgprarup requested a review from saw-jan November 13, 2023 11:33
individual-it
individual-it reviewed Nov 16, 2023
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks generally good. Just some small comments and I would have wished for comments/docs of the new functions

plugin/markdown/plugin.js Outdated Show resolved Hide resolved
plugin/markdown/plugin.js Outdated Show resolved Hide resolved
@grgprarup grgprarup force-pushed the support-metadata-markdown branch from 4379cf1 to 8c2894f Compare November 16, 2023 06:46
@grgprarup grgprarup force-pushed the support-metadata-markdown branch from 8c2894f to 4b4415d Compare November 16, 2023 08:31
@grgprarup grgprarup force-pushed the support-metadata-markdown branch from 4b4415d to 75b44c1 Compare December 11, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@saw-jan saw-jan Awaiting requested review from saw-jan

@individual-it individual-it Awaiting requested review from individual-it

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grgprarup @individual-it @saw-jan