Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use removesuffix instead of strip #4

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

farnoy
Copy link
Contributor

@farnoy farnoy commented Mar 9, 2024

Strip treats the argument as a list of characters to remove across the whole string. What we really want is removesuffix

Copy link
Owner

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Janik-Haag Janik-Haag merged commit aa300e8 into Janik-Haag:main Mar 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants