-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TrackOverlapMetrics
to benchmarking
#117
base: main
Are you sure you want to change the base?
Conversation
Did the benchmarking fail just becuase it had an extra thing to run that wasn't in the baseline? How does the action deal with adding new benchmark functions? |
Honestly I have no idea what's happening. The updated benchmarking runs fine locally for me. I don't think the addition of a new function should cause a problem. We manually make a comparison when we build a pandas dataframe in the "generate report" section. In that case, I think we should just end up with a missing value for the new function on the base commit. @tlambert03 Any guidance on troubleshooting action failures like this? https://github.com/Janelia-Trackathon-2023/traccuracy/actions/runs/6855566985/job/18642828648?pr=117 |
huh, strange. hard to say what's canceling it huh? i would just do some brute force stuff. maybe add |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 83.64% 83.66% +0.01%
==========================================
Files 19 19
Lines 899 900 +1
==========================================
+ Hits 752 753 +1
Misses 147 147 ☔ View full report in Codecov by Sentry. |
No description provided.