Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated API fields #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove deprecated API fields #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions source/PosixClient/Shared/EClientSocketBaseImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1807,9 +1807,9 @@ void EClientSocketBase::placeOrder( OrderId id, const Contract &contract, const
ENCODE_FIELD( order.allOrNone);
ENCODE_FIELD_MAX( order.minQty);
ENCODE_FIELD_MAX( order.percentOffset);
ENCODE_FIELD( order.eTradeOnly);
ENCODE_FIELD( order.firmQuoteOnly);
ENCODE_FIELD_MAX( order.nbboPriceCap);
ENCODE_FIELD( false);
ENCODE_FIELD( false);
ENCODE_FIELD_MAX( UNSET_DOUBLE);
ENCODE_FIELD( order.auctionStrategy); // AUCTION_MATCH, AUCTION_IMPROVEMENT, AUCTION_TRANSPARENT
ENCODE_FIELD_MAX( order.startingPrice);
ENCODE_FIELD_MAX( order.stockRefPrice);
Expand Down Expand Up @@ -3139,9 +3139,12 @@ int EClientSocketBase::processMsg(const char*& beginPtr, const char* endPtr)
DECODE_FIELD( order.allOrNone); // ver 9 field
DECODE_FIELD_MAX( order.minQty); // ver 9 field
DECODE_FIELD( order.ocaType); // ver 9 field
DECODE_FIELD( order.eTradeOnly); // ver 9 field
DECODE_FIELD( order.firmQuoteOnly); // ver 9 field
DECODE_FIELD_MAX( order.nbboPriceCap); // ver 9 field
bool eTradeOnly;
DECODE_FIELD( eTradeOnly); // ver 9 field
bool firmQuoteOnly;
DECODE_FIELD( firmQuoteOnly); // ver 9 field
double nbboPriceCap;
DECODE_FIELD_MAX( nbboPriceCap); // ver 9 field

DECODE_FIELD( order.parentId); // ver 10 field
DECODE_FIELD( order.triggerMethod); // ver 10 field
Expand Down
6 changes: 0 additions & 6 deletions source/PosixClient/Shared/Order.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ struct Order

// SMART routing only
discretionaryAmt = 0;
eTradeOnly = true;
firmQuoteOnly = true;
nbboPriceCap = UNSET_DOUBLE;
optOutSmartRouting = false;

// BOX exchange orders only
Expand Down Expand Up @@ -186,9 +183,6 @@ struct Order

// SMART routing only
double discretionaryAmt;
bool eTradeOnly;
bool firmQuoteOnly;
double nbboPriceCap;
bool optOutSmartRouting;

// BOX exchange orders only
Expand Down