Small fixes #2852
Open
Small fixes #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinatxp
commented
Apr 30, 2023
•
rinatxp
commented
- converting some switch statements to switch expressions;
- other small fixes (null-condition operators, object initializers etc)
sungam3r
reviewed
Apr 30, 2023
Comment on lines
788
to
790
| _writer.Write("/*"); | ||
| _writer.Write(text); | ||
| _writer.Write("*/"); |
There was a problem hiding this comment.
Such calls here are intentionally to avoid string allocations when doing string interpolation.
sungam3r
reviewed
Apr 30, 2023
Src/Newtonsoft.Json/JsonWriter.cs
Outdated
| _currentPosition = _stack[_stack.Count - 1]; | ||
| _stack.RemoveAt(_stack.Count - 1); | ||
| _currentPosition = _stack.Last(); | ||
| _stack.Remove(_stack.Last()); |
There was a problem hiding this comment.
_stack.RemoveAt(_stack.Count - 1); is not the same as _stack.Remove(_stack.Last());
|
Reverted bad commits and added some new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.