Fix tests on polars 1.10 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 21, 2024 11:34
|
Great! And thank you! We'll have to set the minimum version supported to polars 1.10, since with older versions there is some buggy behaviour. I'm currently trying to release a new version, but we'll merge in this one before that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #105
Most of the tests just passed with the 1.10 upgrade.
Still two were failing, but because pola-rs/polars#13602 seems to be fixed now in polars 1.10.
We can revert the hack and all tests passes on polars 1.10.
Should we skip some test for some version of polars in the ci ?