Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite is broken for polars >= 1.7 #105

Closed
dsgibbons opened this issue Oct 16, 2024 · 5 comments · Fixed by #112
Closed

Test suite is broken for polars >= 1.7 #105

dsgibbons opened this issue Oct 16, 2024 · 5 comments · Fixed by #112

Comments

@dsgibbons
Copy link
Contributor

Test output:

FAILED tests/test_dummy_data.py::test_model_example_df - polars.exceptions.InvalidOperationError: Series d, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_dummy_data.py::test_examples - polars.exceptions.InvalidOperationError: Series b, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_dummy_data.py::test_enum_field_example_values - polars.exceptions.InvalidOperationError: Series row_number, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_dummy_data.py::test_nested_models - polars.exceptions.InvalidOperationError: Series parent_field, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_model.py::test_model_example - polars.exceptions.InvalidOperationError: Series float_value, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_model.py::test_mapping_to_polars_dtypes - polars.exceptions.InvalidOperationError: Series str_column, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_model.py::test_missing_date_struct - polars.exceptions.InvalidOperationError: Series b, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_model.py::test_validation_alias - polars.exceptions.InvalidOperationError: Series my_val_a, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_model.py::test_validation_returns_df - polars.exceptions.InvalidOperationError: Series a, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_polars.py::test_create_missing_columns_with_defaults - polars.exceptions.InvalidOperationError: Series bar, length 1 doesn't match the DataFrame height of 2
FAILED tests/test_polars.py::test_create_missing_columns_with_dtype - polars.exceptions.InvalidOperationError: Series bar, length 1 doesn't match the DataFrame height of 2
FAILED tests/test_validators.py::test_drop_superfluous_columns - polars.exceptions.InvalidOperationError: Series column_1, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_validators.py::test_empty_list_validation - patito.exceptions.DataFrameValidationError: 1 validation error for TestModel
FAILED tests/test_validators.py::test_validation_of_bounds_checks - polars.exceptions.InvalidOperationError: Series le_column, length 1 doesn't match the DataFrame height of 0
FAILED tests/test_validators.py::test_validation_of_dtype_specifiers - polars.exceptions.InvalidOperationError: Series int_column, length 1 doesn't match the DataFrame height of 0

I'll add more details once I get a chance to look into this more. In the meantime, I'll raise a brief PR to keep polars <= 1.6

@dhimmel
Copy link

dhimmel commented Oct 17, 2024

Is the issue here that patito's functionality is broken with polars 1.7.0 or just the test suite?

Asking because when installing from main the polars downgrade from 1.9.0 to 1.6.0 was quite large.

@thomasaarholt
Copy link
Collaborator

The biggest problems will hopefully be fixed when polars releases a new minor/patch version (they had a regression), and then we can clean up the rest of the errors. I'd expect a new release within a few days according to their historic schedule.

See the comments in pola-rs/polars#19277.

@thomasaarholt
Copy link
Collaborator

Fixed now!

@dhimmel
Copy link

dhimmel commented Nov 13, 2024

Ah greatly appreciated and sorry to bug the team for another patito release, but would love my project to be on the latest polars (to fix other polars issues I'm hitting).

@thomasaarholt
Copy link
Collaborator

New release out now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants