Color tint support for @BindDrawable #976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure that I want to conflate this attribute with two meanings. Is there a reason you don't want to define the color you're tinting with on the theme? |
|
Yeah, in most cases where I work (especially larger projects) the colors are not associated with the theme or there is a situational basis for the coloring |
Repository owner
deleted a comment from
ivanick87
Jul 31, 2017
…ncoding line to drawable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there Jake!
I'm a great fan of your work :) Something that I noticed was the need for color resource support in the tinting of drawables, the pull request adds
@ColorResannotation for the tint binding and makes the necessary changes to the code for it to work. I expanded the sample activity to include anImageViewthat is tinted in this manner.I hope this meets your standards.
Best regards,
Mohsen Farzone