Add packet size functions and helpers #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a new helper function, `get_file_from_path_or_clip`, that reads the `idx_filepath` if `file=None`. Furthermore, this also splits the function up into sub-functions for readability, and features some speed-ups.
The previous implementation would run two frameevals—once to set the packet sizes of the individual frame, and again to set scene-based ones. This is wasteful. Instead some code has been duplicated into the second frameeval and the first is skipped if Keyframes are passed.
get_packet_size: Docstring updates get_packet_size: Rewrite `out_file`'s param's purpose in docstring
LightArrowsEXE
added a commit
that referenced
this pull request
Sep 25, 2024
* New function: get_packet_sizes * flake8 * get_packet_sizes: Add `out_file` param Also adds a new helper function, `get_file_from_path_or_clip`, that reads the `idx_filepath` if `file=None`. Furthermore, this also splits the function up into sub-functions for readability, and features some speed-ups. * flake8, typo * flake8 * get_packet_sizes: Add Keyframes support * get_packet_scene_stats: Fix iterable argument is empty error * _set_scene_stats: Add back-up prop values * get_packet_sizes: Add additional warning for fallback props * get_packet_sizes: Param to return list of packet sizes * get_packet_scene_stats: Minor typing fix * get_packet_sizes: Add offset parameter * get_packet_sizes: Reduce total frameevals with scening The previous implementation would run two frameevals—once to set the packet sizes of the individual frame, and again to set scene-based ones. This is wasteful. Instead some code has been duplicated into the second frameeval and the first is skipped if Keyframes are passed. * get_packet_sizes: Docstring updates get_packet_size: Docstring updates get_packet_size: Rewrite `out_file`'s param's purpose in docstring * get_packet_sizes: Set packet size to -1 with negative offsets fix typo oops * Move packet functions to own submodule * get_file_from_clip: rewrite old func, add docstring * get_file_from_clip: Add ballback value * get_packet_sizes: filepath -> src_file * get_packet_sizes: get_file_from_path_or_clip -> get_file_from_clip
LightArrowsEXE
added a commit
that referenced
this pull request
Sep 25, 2024
* New function: get_packet_sizes * flake8 * get_packet_sizes: Add `out_file` param Also adds a new helper function, `get_file_from_path_or_clip`, that reads the `idx_filepath` if `file=None`. Furthermore, this also splits the function up into sub-functions for readability, and features some speed-ups. * flake8, typo * flake8 * get_packet_sizes: Add Keyframes support * get_packet_scene_stats: Fix iterable argument is empty error * _set_scene_stats: Add back-up prop values * get_packet_sizes: Add additional warning for fallback props * get_packet_sizes: Param to return list of packet sizes * get_packet_scene_stats: Minor typing fix * get_packet_sizes: Add offset parameter * get_packet_sizes: Reduce total frameevals with scening The previous implementation would run two frameevals—once to set the packet sizes of the individual frame, and again to set scene-based ones. This is wasteful. Instead some code has been duplicated into the second frameeval and the first is skipped if Keyframes are passed. * get_packet_sizes: Docstring updates get_packet_size: Docstring updates get_packet_size: Rewrite `out_file`'s param's purpose in docstring * get_packet_sizes: Set packet size to -1 with negative offsets fix typo oops * Move packet functions to own submodule * get_file_from_clip: rewrite old func, add docstring * get_file_from_clip: Add ballback value * get_packet_sizes: filepath -> src_file * get_packet_sizes: get_file_from_path_or_clip -> get_file_from_clip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.