Fix Part of Issue#3861: Edit->Replace String

CHANGELOG.md

@@ -31,6 +31,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 
 
 
+
 ### Fixed
 - We fixed an issue where custom exports could not be selected in the 'Export (selected) entries' dialog [#4013](https://github.com/JabRef/jabref/issues/4013)
 - Italic text is now rendered correctly. https://github.com/JabRef/jabref/issues/3356
@@ -106,6 +107,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
 
 
 
+
 
 
 ## Older versions

src/main/java/org/jabref/gui/BasePanel.java

@@ -395,32 +395,7 @@ private void setupActions() {
 
         actions.put(Actions.MERGE_WITH_FETCHED_ENTRY, new MergeWithFetchedEntryAction(this, frame.getDialogService()));
 
-        actions.put(Actions.REPLACE_ALL, () -> {
-            final ReplaceStringDialog rsd = new ReplaceStringDialog(frame);
-            rsd.setVisible(true);
-            if (!rsd.okPressed()) {
-                return;
-            }
-            int counter = 0;
-            final NamedCompound ce = new NamedCompound(Localization.lang("Replace string"));
-            if (rsd.selOnly()) {
-                for (BibEntry be : mainTable.getSelectedEntries()) {
-                    counter += rsd.replace(be, ce);
-                }
-            } else {
-                for (BibEntry entry : bibDatabaseContext.getDatabase().getEntries()) {
-                    counter += rsd.replace(entry, ce);
-                }
-            }
-
-            output(Localization.lang("Replaced") + ' ' + counter + ' '
-                    + (counter == 1 ? Localization.lang("occurrence") : Localization.lang("occurrences")) + '.');
-            if (counter > 0) {
-                ce.end();
-                getUndoManager().addEdit(ce);
-                markBaseChanged();
-            }
-        });
+        actions.put(Actions.REPLACE_ALL, ()-> (new ReplaceStringAction(this)).execute());
 
         actions.put(new SpecialFieldValueViewModel(SpecialField.RELEVANCE.getValues().get(0)).getCommand(),
                     new SpecialFieldViewModel(SpecialField.RELEVANCE, undoManager).getSpecialFieldAction(SpecialField.RELEVANCE.getValues().get(0), frame));

src/main/java/org/jabref/gui/ReplaceString.fxml

@@ -0,0 +1,58 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<?import javafx.scene.control.*?>
+<?import javafx.scene.layout.*?>
+
+<DialogPane xmlns:fx="http://javafx.com/fxml/1" xmlns="http://javafx.com/javafx/8"
+            fx:controller="org.jabref.gui.ReplaceStringView">
+    <content>
+        <BorderPane>
+            <center>
+                <BorderPane BorderPane.alignment="CENTER">
+                    <center>
+                        <GridPane>
+                            <columnConstraints>
+                                <ColumnConstraints hgrow="SOMETIMES" minWidth="10.0" prefWidth="100.0"/>
+                                <ColumnConstraints hgrow="SOMETIMES" minWidth="10.0" prefWidth="100.0"/>
+                                <ColumnConstraints hgrow="SOMETIMES" minWidth="10.0" prefWidth="100.0"/>
+                                <ColumnConstraints hgrow="SOMETIMES" minWidth="10.0" prefWidth="100.0"/>
+                                <ColumnConstraints hgrow="SOMETIMES" minWidth="10.0" prefWidth="100.0"/>
+                            </columnConstraints>
+                            <rowConstraints>
+                                <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="SOMETIMES"/>
+                                <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="SOMETIMES"/>
+                                <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="SOMETIMES"/>
+                                <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="SOMETIMES"/>
+                                <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="SOMETIMES"/>
+                                <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="SOMETIMES"/>
+                                <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="SOMETIMES"/>
+                                <RowConstraints minHeight="10.0" prefHeight="30.0" vgrow="SOMETIMES"/>
+                            </rowConstraints>
+                            <Label text="Find and Replace"/>
+                            <Label text="Find: " GridPane.columnIndex="0" GridPane.rowIndex="1"/>
+                            <TextField fx:id="findField" GridPane.columnIndex="1" GridPane.rowIndex="1"
+                                       GridPane.columnSpan="4"/>
+                            <Label text="Replace With:" GridPane.columnIndex="0" GridPane.rowIndex="2"/>
+                            <TextField fx:id="replaceField" GridPane.columnIndex="1" GridPane.rowIndex="2"
+                                       GridPane.columnSpan="4"/>
+                            <CheckBox fx:id="selectFieldOnly" GridPane.columnIndex="0" GridPane.rowIndex="4" GridPane.columnSpan="2"
+                                     text="Limit to Selected Entries"/>
+                            <RadioButton fx:id="allReplace" GridPane.columnIndex="0" GridPane.rowIndex="5" GridPane.columnSpan="2"
+                                         selected="true" text="All Field Replace">
+                                <toggleGroup>
+                                    <ToggleGroup fx:id="radioGroup"/>
+                                </toggleGroup>
+                            </RadioButton>
+                            <RadioButton GridPane.columnIndex="0" GridPane.rowIndex="6" GridPane.columnSpan="2"
+                                         text="Limit to Fields:" toggleGroup="$radioGroup"/>
+                            <TextField fx:id="limitFieldInput" GridPane.columnIndex="2" GridPane.rowIndex="6"
+                                       GridPane.columnSpan="3"/>
+                        </GridPane>
+                    </center>
+                </BorderPane>
+            </center>
+        </BorderPane>
+    </content>
+    <ButtonType fx:id="replaceButton" text="Replace" buttonData="OK_DONE"/>
+    <ButtonType fx:constant="CANCEL"/>
+</DialogPane>

src/main/java/org/jabref/gui/ReplaceStringAction.java

@@ -0,0 +1,18 @@
+package org.jabref.gui;
+
+import org.jabref.gui.actions.SimpleCommand;
+
+public class ReplaceStringAction extends SimpleCommand
+{
+    private BasePanel basePanel;
+
+    public ReplaceStringAction(BasePanel basePanel) {
+        this.basePanel = basePanel;
+    }
+
+    @Override
+    public void execute() {
+        ReplaceStringView dialog = new ReplaceStringView(basePanel);
+        dialog.showAndWait();
+    }
+}