Add notice on usage of local models #12298
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
| BorderPane.alignment="CENTER"/> | ||
| <VBox fx:id="noticeVbox" spacing="5" alignment="CENTER"> | ||
| <Label fx:id="noticeText" | ||
| text="%Current AI model: %0. This content is generated by an AI system. Please verify its accuracy and relevance before use." |
There was a problem hiding this comment.
I think the second sentence is redundant after the first is read. Also, the third sentence ends with "before use" - but accuracy can be verified only after the content is generated.
Based on chatgpt:
Three possible suggestions:
| text="%Current AI model: %0. This content is generated by an AI system. Please verify its accuracy and relevance before use." | |
| text="%Current AI model: %0. AI generated content may not always be accurate. Verify any important information." |
Or:
| text="%Current AI model: %0. This content is generated by an AI system. Please verify its accuracy and relevance before use." | |
| text="%Current AI model: %0. Always verify the correctness of any important information." |
Or:
| text="%Current AI model: %0. This content is generated by an AI system. Please verify its accuracy and relevance before use." | |
| text="%Current AI model: %0. Please always verify the correctness of AI-generated content." |
and other permutations...
There was a problem hiding this comment.
Ha! I haven't looked at "Current model:...". But you are right. I rewrote the message a bit now, what do you think about it now?
There was a problem hiding this comment.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
There was a problem hiding this comment.
JUnit tests are failing. In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details". This brings you to the test output.
You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.
| BorderPane.alignment="CENTER"/> | ||
| <VBox fx:id="noticeVbox" spacing="5" alignment="CENTER"> | ||
| <Label fx:id="noticeText" | ||
| text="%You are using AI model: %0. AI generated content may not always be accurate. Verify any important information." |
There was a problem hiding this comment.
| text="%You are using AI model: %0. AI generated content may not always be accurate. Verify any important information." | |
| text="%You are using AI model \"%0\". AI generated content may not always be accurate. Verify any important information." |
I hope this works. Reason to use quotes: AI model names may contain spaces - and maybe dots. With that change, it should be visible to the users...
| @@ -109,6 +110,10 @@ private void initializeNotice() { | |||
| .replaceAll("%0", aiPreferences.getAiProvider().getLabel() + " " + aiPreferences.getSelectedChatModel()); | |||
|
|
|||
| noticeText.setText(newNotice); | |||
|
|
|||
| if (aiPreferences.isUnsafeModelSelected()) { | |||
| noticeVbox.getChildren().add(new Label(Localization.lang("A custom or local AI model is used, JabRef is not responsible for the content generated by the model."))); | |||
There was a problem hiding this comment.
What about the other models? Do we take responsibility? I hope not :).
Proposal: "A model not covered by the EU AI act is selected. Use with extra care."
| * are subject to the EU AI act. However, when user selects a local model or models from Hugging Face, then any model | ||
| * can be used in JabRef, including uncensored and harmful ones. | ||
| */ | ||
| public boolean isUnsafeModelSelected() { |
There was a problem hiding this comment.
Rename to isSubjectToEuAiAct?
In all cases do NOT use negations in the method name. Use isSafeModelSelected.
Changes:
OpenAItoOpenAI (or API compatible).Rationales:
Mandatory checks
- [ ] Change inCHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)- [ ] Tests created for changes (if applicable)- [x] Manually tested changed features in running JabRef (always required)