Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force no fullscreen #11991

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Force no fullscreen #11991

wants to merge 1 commit into from

Conversation

calixtus
Copy link
Member

This is a test PR
tries to fix #10731
Please test with Mint/Cinnamon

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

The build of this PR is available at https://builds.jabref.org/pull/11991/merge.

@koppor
Copy link
Member

koppor commented Oct 23, 2024

Report from #10731 (comment)

  • If Jabref is closed while in fullscreen (e.g. through ALT+F4), it will start in fullscreen on the next startup.
  • If Jabref is taken out of fullscreen, it becomes windowed and maximised. If I close it while windowed+maximised, it will start in fullscreen on the next startup, and not windowed+maximised.
  • If Jabref is taken out of fullscreen and then unmaximised, it will open windowed+unmaximised on the next startup.

@Siedlerchr
Copy link
Member

I observed that the property isMaximized reports wrong values on closing JabRef under mac when it was set to true at startup. Even after resizing it never changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't escape full screen + menus stay closed (after upgrade to 5.12/5.13)
3 participants