[WIP] This relativizes the PDF's filepaths after importing through "Find Unlinked Files"

src/main/java/org/jabref/gui/externalfiles/ImportHandler.java

@@ -116,7 +116,10 @@ protected List<ImportFilesResultItemViewModel> call() {
 
                     try {
                         if (FileUtil.isPDFFile(file)) {
-                            var pdfImporterResult = contentImporter.importPDFContent(file);
+                            var filePreferences = preferencesService.getFilePreferences();
+                            Path workingDir = bibDatabaseContext.getFirstExistingFileDir(filePreferences)
+                                    .orElse(filePreferences.getWorkingDirectory());
+                            var pdfImporterResult = contentImporter.importPDFContent(file, workingDir);
                             List<BibEntry> pdfEntriesInFile = pdfImporterResult.getDatabase().getEntries();
 
                             if (pdfImporterResult.hasWarnings()) {

src/main/java/org/jabref/logic/externalfiles/ExternalFilesContentImporter.java

@@ -17,9 +17,9 @@ public ExternalFilesContentImporter(ImportFormatPreferences importFormatPreferen
         this.importFormatPreferences = importFormatPreferences;
     }
 
-    public ParserResult importPDFContent(Path file) {
+    public ParserResult importPDFContent(Path file, Path workingDir) {
         try {
-            return new PdfMergeMetadataImporter(importFormatPreferences).importDatabase(file);
+            return new PdfMergeMetadataImporter(importFormatPreferences).importDatabase(file, workingDir);
         } catch (IOException e) {
            return ParserResult.fromError(e);
         }

src/main/java/org/jabref/logic/importer/fileformat/PdfMergeMetadataImporter.java

@@ -72,6 +72,20 @@ public ParserResult importDatabase(String data) throws IOException {
 
     @Override
     public ParserResult importDatabase(Path filePath) throws IOException {
+        return importDatabase(filePath, null);
+    }
+
+    /**
+     * Same as {@link PdfMergeMetadataImporter#importDatabase(Path)}, but this
+     * relativizes the {@code filePath}, if {@code workingDir} is not null
+     * (otherwise no path modification happens).
+     *
+     * @param filePath    the path to the file which should be imported
+     * @param workingDir  one of the directories
+     *                    {@link BibDatabaseContext#getFileDirectories(FilePreferences) mentioned here}
+     *                    set up for this database
+     */
+    public ParserResult importDatabase(Path filePath, Path workingDir) throws IOException {
         List<BibEntry> candidates = new ArrayList<>();
 
         for (Importer metadataImporter : metadataImporters) {
@@ -124,7 +138,9 @@ public ParserResult importDatabase(Path filePath) throws IOException {
                 }
             }
         }
-
+        if (workingDir != null) {
+            filePath = workingDir.relativize(filePath);
+        }
         entry.addFile(new LinkedFile("", filePath, StandardFileType.PDF.getName()));
         return new ParserResult(List.of(entry));
     }

src/test/java/org/jabref/logic/importer/fileformat/PdfMergeMetadataImporterTest.java

@@ -95,4 +95,19 @@ void importWorksAsExpected() throws Exception {
 
         assertEquals(Collections.singletonList(expected), result);
     }
+
+    @Test
+    void pathShouldBeRelativized() throws Exception {
+        Path file = Path.of(PdfMergeMetadataImporter.class.getResource("/pdfs/minimal.pdf").toURI());
+        Path workingDir = Path.of(PdfMergeMetadataImporter.class.getResource("/pdfs/").toURI());
+        List<BibEntry> result = importer.importDatabase(file, workingDir).getDatabase().getEntries();
+
+        BibEntry expected = new BibEntry(StandardEntryType.InProceedings)
+                .withField(StandardField.AUTHOR, "1 ")
+                .withField(StandardField.TITLE, "Hello World")
+                // Expecting relative path
+                .withField(StandardField.FILE, ":minimal.pdf:PDF");
+
+        assertEquals(List.of(expected), result);
+    }
 }