Skip to content

Commit

Permalink
Replace "entry(ies)" by "entry(s)"
Browse files Browse the repository at this point in the history
  • Loading branch information
koppor committed Oct 30, 2024
1 parent 7232836 commit 9bb57ad
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
3 changes: 2 additions & 1 deletion docs/code-howtos/localization.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ To write a localized string in FXML file, prepend it with `%`, like in this code
## General hints

* Use the String you want to localize directly, do not use members or local variables: `Localization.lang("Translate me");` instead of `Localization.lang(someVariable)` (possibly in the form `someVariable = Localization.lang("Translate me")`
* Use `%x`-variables where appropriate: `Localization.lang("Exported %0 entries.", number)` instead of `Localization.lang("Exported ") + number + Localization.lang(" entries.");`
* Use `%x`-variables where appropriate: `Localization.lang("Exported %0 entry(s).", number)` instead of `Localization.lang("Exported ") + number + Localization.lang(" entry(s).");`
* Use a full stop/period (".") to end full sentences
* For pluralization, use a combined form. E.g., `Localization.lang("checked %0 entry(s)")`.

## Checking for correctness

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/jabref/gui/LibraryTab.java
Original file line number Diff line number Diff line change
Expand Up @@ -906,7 +906,7 @@ public void insertEntries(final List<BibEntry> entries) {
public void copyEntry() {
int entriesCopied = doCopyEntry(getSelectedEntries());
if (entriesCopied >= 0) {
dialogService.notify(Localization.lang("Copied %0 entry(ies)", entriesCopied));
dialogService.notify(Localization.lang("Copied %0 entry(s)", entriesCopied));
} else {
dialogService.notify(Localization.lang("Copy failed", entriesCopied));
}
Expand Down Expand Up @@ -970,7 +970,7 @@ public void cutEntry() {
int entriesDeleted = doDeleteEntry(StandardActions.CUT, mainTable.getSelectedEntries());

if (entriesCopied == entriesDeleted) {
dialogService.notify(Localization.lang("Cut %0 entry(ies)", entriesCopied));
dialogService.notify(Localization.lang("Cut %0 entry(s)", entriesCopied));
} else {
dialogService.notify(Localization.lang("Cut failed", entriesCopied));
undoManager.undo();
Expand All @@ -983,7 +983,7 @@ public void cutEntry() {
*/
public void deleteEntry() {
int entriesDeleted = doDeleteEntry(StandardActions.DELETE_ENTRY, mainTable.getSelectedEntries());
dialogService.notify(Localization.lang("Deleted %0 entry(ies)", entriesDeleted));
dialogService.notify(Localization.lang("Deleted %0 entry(s)", entriesDeleted));
}

public void deleteEntry(BibEntry entry) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
import org.slf4j.LoggerFactory;

/**
* Try to download fulltext PDF for selected entry(ies) by following URL or DOI link.
* Try to download fulltext PDF for selected entry(s) by following URL or DOI link.
*/
public class DownloadFullTextAction extends SimpleCommand {

Expand Down
6 changes: 3 additions & 3 deletions src/main/resources/l10n/JabRef_en.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2768,9 +2768,9 @@ Pushing\ citations\ to\ TeXShop\ is\ only\ possible\ on\ macOS\!=Pushing citatio
Single\ instance=Single instance
Copied\ %0\ entry(ies)=Copied %0 entry(ies)
Cut\ %0\ entry(ies)=Cut %0 entry(ies)
Deleted\ %0\ entry(ies)=Deleted %0 entry(ies)
Copied\ %0\ entry(s)=Copied %0 entry(s)
Cut\ %0\ entry(s)=Cut %0 entry(s)
Deleted\ %0\ entry(s)=Deleted %0 entry(s)
Enable\ Journal\ Information\ Fetching?=Enable Journal Information Fetching?
Would\ you\ like\ to\ enable\ fetching\ of\ journal\ information?\ This\ can\ be\ changed\ later\ in\ %0\ >\ %1.=Would you like to enable fetching of journal information? This can be changed later in %0 > %1.
Expand Down

0 comments on commit 9bb57ad

Please sign in to comment.