Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from the discussion here #202 and working towards a v1.0.0 release, this pull request enforces the use of section properties when defining Member3D elements. This simplifies the processes of creating Member3D objects, by effectively grouping parameters to be passed to the
__init__
method. It also ensures consistency in the way that section properties are stored within the FEA model, which is critical as the package matures.This pull request also alters the Member3D class logic slightly, so that the section and material properties are not extracted in the Member3D
__init__
method, but instead accessed directly from the appropriate section or material instances during analysis. This enables simple alteration of section or material properties between analysis runs, with the confidence that any changes are propogated through to all members referencin gthe given section or material.The same approach could be taken for Quad & Plate elements, but can be covered in a different pull request.
These changes will break most user's code.