Cancelar tickets no pagados en cron de sync de pagos #272
+419
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
TextC0de
commented
Sep 18, 2024
| @@ -21,7 +21,7 @@ const googleMediaType = { | |||
| }, | |||
| }; | |||
|
|
|||
| describe("Test email library", () => { | |||
| describe("Test email library on Google Import", () => { | |||
There was a problem hiding this comment.
Se renombraron nombres de tests repetidos
| @@ -674,5 +675,19 @@ export const clearExpiredPurchaseOrders = async ({ | |||
| ) | |||
| .returning(); | |||
|
|
|||
| if (expiredOrders.length > 0) { | |||
There was a problem hiding this comment.
Los tickets asociados a las ordenes expiradas deben ser cancelados para poder liberar ese stock
| @@ -40,6 +40,7 @@ export const scheduled: ExportedHandlerScheduledHandler<ENV> = async ( | |||
| const getUnpaidPurchaseOrders = await DB.query.purchaseOrdersSchema.findMany({ | |||
| where: (po, { eq, and, isNotNull }) => | |||
| and( | |||
| eq(po.status, "open"), | |||
There was a problem hiding this comment.
Solo necesitamos las ordenes que esten "open".
Las "complete" o "expired" no nos deberían interesar
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
TextC0de
changed the title
fforres
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Este PR realiza las siguientes mejoras y correcciones:
Cancela los tickets asociados a órdenes de compra expiradas en el cron de sincronización de pagos:
clearExpiredPurchaseOrderspara cancelar los tickets vinculados a órdenes expiradas.scheduled.test.tspara verificar que los tickets se cancelen correctamente.Mejora la sincronización de pagos: