Alais29/sanity footer #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
Deploying 2024 with
|
| Latest commit: |
ce18a59
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0f6c71c0.2024-9yz.pages.dev |
| Branch Preview URL: | https://alais29-sanity-footer.2024-9yz.pages.dev |
|
Replaced Header code for the one merged in #47 |
…inks props don't exist
joseglego
reviewed
Jun 8, 2024
| @@ -1,35 +1,50 @@ | |||
| import { defineField, defineType } from 'sanity' | |||
| import { defineField, defineType } from "sanity"; | |||
There was a problem hiding this comment.
Me gusto esto! Muchas gracias 👍
joseglego
reviewed
Jun 8, 2024
| @@ -14,7 +14,8 @@ | |||
| "lint:fix": "eslint ./src --cache --fix", | |||
There was a problem hiding this comment.
Creo que este tipo de cambios es mejor discutirlos antes. Para hacer sync :)
joseglego
reviewed
Jun 8, 2024
| href={link.url ?? ""} | ||
| target={link.target ?? ""} | ||
| className={cn( | ||
| "flex font-barlow justify-center gap-2 p-4 py-2", |
There was a problem hiding this comment.
Muchos espacios en blanco innecesarios. Quizás deberíamos tener algo para esto automatizado 🤔 (noté que la versión anterior también tiene.
joseglego
reviewed
Jun 8, 2024
| @@ -14,6 +14,8 @@ const linkVariants = cva( | |||
| default: "bg-jsconf-yellow text-black hover:bg-[#C8BC4F]", | |||
| outline: | |||
| "border border-jsconf-yellow bg-stone-950 text-white hover:bg-stone-900", | |||
| link: "mb-0 w-auto p-0 text-base font-normal hover:text-jsconf-yellow", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UI
Before:
After: