Skip to content

feat(publicToken): include meta=image #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(publicToken): include meta=image #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pages/p/ticket/[id].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ const TicketPage = ({
name="description"
content="Mi Ticket para la JSConf Chile. Obtén tu ticket acá!"
/>

<meta
property="og:url"
content={`https://jsconf.cl/p/ticket/${cleanedId}`}
Expand All @@ -46,6 +45,7 @@ const TicketPage = ({
content="Mi Ticket para la JSConf Chile. Obtén tu ticket acá!"
/>
<meta
name="image"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se probó agregando width y height, Esto según recomendación mía, ya que hace poco solucioné el mismo problema de las imágenes en LinkedIn agregando esas metas

FYI: Puedes leer mas sobre este meta acá

property="og:image"
content={`${ticketApiUrl}/ticket/image/${ticket.ticketId}`}
/>
Expand Down